-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve perf of JsonValue.CreateFromElement by calling ValueKind once #104108
Merged
eiriktsarpalis
merged 4 commits into
dotnet:main
from
andrewjsaid:jsonvalue-createfromelement-minor-perf
Jul 1, 2024
Merged
Improve perf of JsonValue.CreateFromElement by calling ValueKind once #104108
eiriktsarpalis
merged 4 commits into
dotnet:main
from
andrewjsaid:jsonvalue-createfromelement-minor-perf
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lueKind only once
dotnet-policy-service
bot
added
the
community-contribution
Indicates that the PR has been added by a community member
label
Jun 27, 2024
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValue.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 27, 2024
Open
src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValue.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValue.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-System.Text.Json
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #104048 (comment)
JsonElement.ValueKind
actually does quite a few operations as described below. This PR is a small change so that it's only called once.cc @eiriktsarpalis